-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support create table SQL statement (#424) #653
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## master #653 +/- ##
==========================================
+ Coverage 36.90% 36.99% +0.08%
==========================================
Files 203 213 +10
Lines 22340 23044 +704
==========================================
+ Hits 8245 8525 +280
- Misses 13178 13595 +417
- Partials 917 924 +7
... and 15 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
1、shadow非核心功能,暂时忽略; 求review~~ |
maybe we should squash the commits or just open a new pr to make the commit message cleaner? It's 25 commits now and there's much commit history about 'merge'. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you unify the same capitalization of error messages in the project?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hi @Mulavar , we use |
【done】1、非命中shadow rule,非命中sharding rule:穿透到0库建表;
【done】2、非命中shadow rule,命中sharding rule:建分区表;
【todo】3、命中shadow rule,非命中sharding rule:穿透到0库建影子表;
【todo】4、命中shadow rule,命中sharding rule:建影子分区表;
另外,建表语句还需完善,暂时别合入,: )